linux-ext4 - Re: [PATCH linux-kselftest/test v6] ext4: add kunit test for decoding extended timestamps

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <73ef528c-6424-351c-c07c-d0d5b4ebb02e@linuxfoundation.org>
Date:   Thu, 17 Oct 2019 16:21:08 -0600
From:   Shuah Khan <skhan@...uxfoundation.org>
To:     Iurii Zaikin <yzaikin@...gle.com>, linux-kselftest@...r.kernel.org,
        linux-ext4@...r.kernel.org, tytso@....edu,
        adilger.kernel@...ger.ca, Tim.Bird@...y.com
Cc:     kunit-dev@...glegroups.com, brendanhiggins@...gle.com,
        Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [PATCH linux-kselftest/test v6] ext4: add kunit test for decoding
 extended timestamps

On 10/17/19 4:12 PM, Iurii Zaikin wrote:
> KUnit tests for decoding extended 64 bit timestamps that verify the
> seconds part of [a/c/m] timestamps in ext4 inode structs are decoded
> correctly.
> 
> Test data is derived from the table in the Inode Timestamps section of
> Documentation/filesystems/ext4/inodes.rst.
> 
> KUnit tests run during boot and output the results to the debug log
> in TAP format (http://testanything.org/). Only useful for kernel devs
> running KUnit test harness and are not for inclusion into a production
> build.
> 
> Signed-off-by: Iurii Zaikin <yzaikin@...gle.com>
> Reviewed-by: Theodore Ts'o <tytso@....edu>
> Reviewed-by: Brendan Higgins <brendanhiggins@...gle.com>
> Tested-by: Brendan Higgins <brendanhiggins@...gle.com>

Looks good.

Reviewed-by: Shuah Khan <skhan@...uxfoundation.org>

I plan to apply this to linux-kselftest/test

thanks,
-- Shuah