linux-ext4 - Re: [PATCH linux-kselftest/test v2] ext4: add kunit test for decoding extended timestamps

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <56189643-af2b-f754-bc95-60ab4f126c32@linuxfoundation.org>
Date:   Thu, 17 Oct 2019 17:42:55 -0600
From:   Shuah Khan <skhan@...uxfoundation.org>
To:     Iurii Zaikin <yzaikin@...gle.com>
Cc:     "Theodore Y. Ts'o" <tytso@....edu>,
        Brendan Higgins <brendanhiggins@...gle.com>,
        "open list:KERNEL SELFTEST FRAMEWORK" 
        <linux-kselftest@...r.kernel.org>, linux-ext4@...r.kernel.org,
        adilger.kernel@...ger.ca,
        KUnit Development <kunit-dev@...glegroups.com>,
        Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [PATCH linux-kselftest/test v2] ext4: add kunit test for decoding
 extended timestamps

On 10/17/19 5:27 PM, Iurii Zaikin wrote:
>> You can do all of this and allow users to supply another set of data.
>> It doesn't gave to be one or the other.
>>
> What is the use case for running a unit test on a different data set than
> what it comes with?
> 

Let me ask the question in a different way. I would like to see the
ability supply test data at run-time. It can be the same data every
single time the test runs.

I am not seeing the reasons to embed the test data in the test itself.

thanks,
-- Shuah