linux-ext4 - Re: [PATCH 07/22] ext4: Avoid unnecessary revokes in ext4_alloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 21 Oct 2019 09:39:56 -0400
From:   "Theodore Y. Ts'o" <tytso@....edu>
To:     Jan Kara <jack@...e.cz>
Cc:     linux-ext4@...r.kernel.org
Subject: Re: [PATCH 07/22] ext4: Avoid unnecessary revokes in
 ext4_alloc_branch()

On Fri, Oct 04, 2019 at 12:05:53AM +0200, Jan Kara wrote:
> Error cleanup path in ext4_alloc_branch() calls ext4_forget() on freshly
> allocated indirect blocks with 'metadata' set to 1. This results in
> generating revoke records for these blocks. However this is unnecessary
> as the freed blocks are only allocated in the current transaction and
> thus they will never be journalled. Make this cleanup path similar to
> e.g. cleanup in ext4_splice_branch() and use ext4_free_blocks() to
> handle block forgetting by passing EXT4_FREE_BLOCKS_FORGET and not
> EXT4_FREE_BLOCKS_METADATA to ext4_free_blocks(). This also allows
> allocating transaction not to reserve any credits for revoke records.
> 
> Signed-off-by: Jan Kara <jack@...e.cz>

Looks good, you can add:

Reviewed-by: Theodore Ts'o <tytso@....edu>