linux-ext4 - Re: [PATCH v3 01/13] ext4: add handling for extended mount options

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAD+ocbyMyfp8gF7Q2=c7_w-=p5BPdsPmCFaCS_4iKb=8r=Rrxg@mail.gmail.com>
Date:   Mon, 21 Oct 2019 13:41:14 -0700
From:   harshad shirwadkar <harshadshirwadkar@...il.com>
To:     "Theodore Y. Ts'o" <tytso@....edu>
Cc:     Ext4 Developers List <linux-ext4@...r.kernel.org>,
        Andreas Dilger <adilger@...ger.ca>
Subject: Re: [PATCH v3 01/13] ext4: add handling for extended mount options

On Tue, Oct 15, 2019 at 7:14 PM Theodore Y. Ts'o <tytso@....edu> wrote:
>
> On Tue, Oct 01, 2019 at 12:40:50AM -0700, Harshad Shirwadkar wrote:
> > @@ -1858,8 +1863,9 @@ static int handle_mount_opt(struct super_block *sb, char *opt, int token,
> >                       set_opt2(sb, EXPLICIT_DELALLOC);
> >               } else if (m->mount_opt & EXT4_MOUNT_JOURNAL_CHECKSUM) {
> >                       set_opt2(sb, EXPLICIT_JOURNAL_CHECKSUM);
> > -             } else
> > +             } else if (m->mount_opt) {
> >                       return -1;
> > +             }
> >       }
> >       if (m->flags & MOPT_CLEAR_ERR)
> >               clear_opt(sb, ERRORS_MASK);
>
> Why is this change needed?  This is in the handling of options that
> have MOPT_EXPLICIT, and it doesn't seem relevant to this commit?
You are right, this change is an irrelevant change. I'll remove it in
next version. Thanks!
>
>                                                  - Ted