lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20191023131546.GB2460@mit.edu>
Date:   Wed, 23 Oct 2019 09:15:46 -0400
From:   "Theodore Y. Ts'o" <tytso@....edu>
To:     Ext4 Developers List <linux-ext4@...r.kernel.org>
Subject: Re: [PATCH] ext4: fix signed vs unsigned comparison in
 ext4_valid_extent()

On Tue, Oct 22, 2019 at 10:44:47PM -0700, Eric Biggers wrote:
> 
> This patch can't be fixing anything because the comparison is unsigned both
> before and after this patch.

Thanks, you're right; I had forgotten C's signed/unsigned rules for
addition.  The funny thing is the original reporter of BZ #205197
reported that the problem went away he tried a similar patch.

	      	  	       	    - Ted

Powered by blists - more mailing lists