linux-ext4 - Re: [PATCH] ext2: don't set count in the case of failure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20191025130237.GA30163@quack2.suse.cz>
Date:   Fri, 25 Oct 2019 15:02:37 +0200
From:   Jan Kara <jack@...e.cz>
To:     Chengguang Xu <cgxu519@...ernel.net>
Cc:     jack@...e.com, linux-ext4@...r.kernel.org
Subject: Re: [PATCH] ext2: don't set count in the case of failure

On Tue 22-10-19 17:27:20, Chengguang Xu wrote:
> In the case of failure, the num is still initialized value 0
> so we should not set it to *count because it will bring
> unexpected side effect to the caller.
> 
> Signed-off-by: Chengguang Xu <cgxu519@...ernel.net>

Looks good to me but please ellaborate a bit in the changelog what are
visible effects of this bug. Thanks!

								Honza

> ---
>  fs/ext2/balloc.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/fs/ext2/balloc.c b/fs/ext2/balloc.c
> index 18e75adcd2f6..cc516c7b7974 100644
> --- a/fs/ext2/balloc.c
> +++ b/fs/ext2/balloc.c
> @@ -736,7 +736,6 @@ ext2_try_to_allocate(struct super_block *sb, int group,
>  	*count = num;
>  	return grp_goal - num;
>  fail_access:
> -	*count = num;
>  	return -1;
>  }
>  
> -- 
> 2.20.1
> 
> 
> 
-- 
Jan Kara <jack@...e.com>
SUSE Labs, CR