linux-ext4 - Re: [PATCH] fs: ext4: remove unused variable warning in parse

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20191114225940.GE4579@mit.edu>
Date:   Thu, 14 Nov 2019 17:59:40 -0500
From:   "Theodore Y. Ts'o" <tytso@....edu>
To:     Ritesh Harjani <riteshh@...ux.ibm.com>
Cc:     Olof Johansson <olof@...om.net>, adilger.kernel@...ger.ca,
        linux-ext4@...r.kernel.org, linux-kernel@...r.kernel.org,
        Jan Kara <jack@...e.cz>
Subject: Re: [PATCH] fs: ext4: remove unused variable warning in
 parse_options()

On Tue, Nov 12, 2019 at 09:53:39PM +0530, Ritesh Harjani wrote:
> 
> 
> On 11/11/19 7:55 AM, Olof Johansson wrote:
> > Commit c33fbe8f673c5 ("ext4: Enable blocksize < pagesize for
> > dioread_nolock") removed the only user of 'sbi' outside of the ifdef,
> > so it caused a new warning:
> > 
> > fs/ext4/super.c:2068:23: warning: unused variable 'sbi' [-Wunused-variable]
> > 
> > Fixes: c33fbe8f673c5 ("ext4: Enable blocksize < pagesize for dioread_nolock")
> > Signed-off-by: Olof Johansson <olof@...om.net>
> 
> hmm, I see that I had CONFIG_QUOTA enabled, so missed this.
> Thanks for the patch.
> 
> You may add:
> Reviewed-by: Ritesh Harjani <riteshh@...ux.ibm.com>

Thanks, applied.

					- Ted