lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Fri, 15 Nov 2019 11:22:27 -0800
From:   Eric Biggers <>
To:     Jarkko Sakkinen <>
Cc:, "Theodore Y . Ts'o" <>,
        Jaegeuk Kim <>,
        Paul Crowley <>,
        Paul Lawrence <>,,,,, David Howells <>,
        Ondrej Mosnacek <>,
        Ondrej Kozina <>
Subject: Re: [PATCH] fscrypt: support passing a keyring key to

On Fri, Nov 15, 2019 at 07:28:53PM +0200, Jarkko Sakkinen wrote:
> I don't see anything obviously wrong. Just would reformat it a bit.
> How you tested it?

I'm not sure all the blank lines you're suggesting would be an improvement.
The ones in fscrypt_provisioning_key_preparse() might make sense though.

I'm working on an xfstest for this:

It's not quite ready, though.  I'll post it for review when it is.

Someone is also planning to update Android userspace to use this.  So if there
are any issues from that, I'll hear about it.

- Eric

Powered by blists - more mailing lists