lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 16 Nov 2019 17:33:36 -0800 From: Stephen Boyd <sboyd@...nel.org> To: Alan Maguire <alan.maguire@...cle.com>, brendanhiggins@...gle.com, linux-kselftest@...r.kernel.org, skhan@...uxfoundation.org Cc: linux-kernel@...r.kernel.org, kunit-dev@...glegroups.com, keescook@...omium.org, yzaikin@...gle.com, akpm@...ux-foundation.org, yamada.masahiro@...ionext.com, catalin.marinas@....com, joe.lawrence@...hat.com, penguin-kernel@...ove.sakura.ne.jp, schowdary@...dia.com, urezki@...il.com, andriy.shevchenko@...ux.intel.com, corbet@....net, tytso@....edu, adilger.kernel@...ger.ca, mcgrof@...nel.org, changbin.du@...el.com, linux-ext4@...r.kernel.org, linux-doc@...r.kernel.org, Alan Maguire <alan.maguire@...cle.com>, Knut Omang <knut.omang@...cle.com> Subject: Re: [PATCH v4 linux-kselftest-test 1/6] kunit: move string-stream.h to lib/kunit Quoting Alan Maguire (2019-11-15 02:16:07) > string-stream interfaces are not intended for external use; > move them from include/kunit to lib/kunit accordingly. > > Signed-off-by: Alan Maguire <alan.maguire@...cle.com> > Signed-off-by: Knut Omang <knut.omang@...cle.com> The sign off chain is incorrect here. Is Knut tag supposed to be Co-developed-by? > diff --git a/include/kunit/assert.h b/include/kunit/assert.h > index db6a0fc..ad889b5 100644 > --- a/include/kunit/assert.h > +++ b/include/kunit/assert.h > @@ -9,10 +9,11 @@ > #ifndef _KUNIT_ASSERT_H > #define _KUNIT_ASSERT_H > > -#include <kunit/string-stream.h> > #include <linux/err.h> > +#include <linux/kernel.h> Why is this included now? > > struct kunit; > +struct string_stream; > > /** > * enum kunit_assert_type - Type of expectation/assertion.
Powered by blists - more mailing lists