linux-ext4 - Re: [PATCH v4 linux-kselftest-test 2/6] kunit: hide unexported try-catch interface in try-catch-impl.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 18 Nov 2019 17:30:48 +0000 (GMT)
From:   Alan Maguire <alan.maguire@...cle.com>
To:     Stephen Boyd <sboyd@...nel.org>
cc:     Alan Maguire <alan.maguire@...cle.com>, brendanhiggins@...gle.com,
        linux-kselftest@...r.kernel.org, skhan@...uxfoundation.org,
        linux-kernel@...r.kernel.org, kunit-dev@...glegroups.com,
        keescook@...omium.org, yzaikin@...gle.com,
        akpm@...ux-foundation.org, yamada.masahiro@...ionext.com,
        catalin.marinas@....com, joe.lawrence@...hat.com,
        penguin-kernel@...ove.sakura.ne.jp, schowdary@...dia.com,
        urezki@...il.com, andriy.shevchenko@...ux.intel.com,
        corbet@....net, tytso@....edu, adilger.kernel@...ger.ca,
        mcgrof@...nel.org, changbin.du@...el.com,
        linux-ext4@...r.kernel.org, linux-doc@...r.kernel.org
Subject: Re: [PATCH v4 linux-kselftest-test 2/6] kunit: hide unexported
 try-catch interface in try-catch-impl.h

On Sat, 16 Nov 2019, Stephen Boyd wrote:
> Quoting Alan Maguire (2019-11-15 02:16:08)
> > diff --git a/lib/kunit/try-catch-impl.h b/lib/kunit/try-catch-impl.h
> > new file mode 100644
> > index 0000000..e308d5c
> > --- /dev/null
> > +++ b/lib/kunit/try-catch-impl.h
> > @@ -0,0 +1,28 @@
> > +/* SPDX-License-Identifier: GPL-2.0 */
> > +/*
> > + * An API to allow a function, that may fail, to be executed, and recover in a
> 
> This file is not an API. Maybe just say "Internal kunit try catch
> implementation details to be shared with tests".
>

Thanks for the review! Will fix this, along with adding the
"Co-developed-by:" for Knut and will remove the unneeded
#include of linux/kernel.h in v5 mentioned in the patch
1 review. Thanks again!

Alan

> > + * controlled manner.
> > + *
> > + * Copyright (C) 2019, Google LLC.
> > + * Author: Brendan Higgins <brendanhiggins@...gle.com>
> > + */
> > +
> > +#ifndef _KUNIT_TRY_CATCH_IMPL_H
> > +#define _KUNIT_TRY_CATCH_IMPL_H
> > +
> > +#include <kunit/try-catch.h>
> > +#include <linux/types.h>
> > +
> > +struct kunit;
> > +
> > +static inline void kunit_try_catch_init(struct kunit_try_catch *try_catch,
> > +                                       struct kunit *test,
> > +                                       kunit_try_catch_func_t try,
>