linux-ext4 - Re: [PATCH -v2] ext4: add more paranoia checking in ext4_expand_extra

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 18 Nov 2019 18:15:26 -0800
From:   Eric Biggers <ebiggers@...nel.org>
To:     "Theodore Y. Ts'o" <tytso@....edu>
Cc:     kbuild test robot <lkp@...el.com>, kbuild-all@...ts.01.org,
        Ext4 Developers List <linux-ext4@...r.kernel.org>,
        syzbot+f8d6f8386ceacdbfff57@...kaller.appspotmail.com,
        stable@...nel.org
Subject: Re: [PATCH -v2] ext4: add more paranoia checking in
 ext4_expand_extra_isize handling

On Sun, Nov 10, 2019 at 07:15:10AM -0500, Theodore Y. Ts'o wrote:
> I hadn't gotten around to resending the patch.  The original version
> had a number of last-minute typos that had crept in...
> 
>       	     		    	       	   - Ted
> 
> From a67ad537964d10f94a4b990c084365e75316cde8 Mon Sep 17 00:00:00 2001
> From: Theodore Ts'o <tytso@....edu>
> Date: Thu, 7 Nov 2019 21:43:41 -0500
> Subject: [PATCH] ext4: add more paranoia checking in ext4_expand_extra_isize
>  handling
> 
> 
> It's possible to specify a non-zero s_want_extra_isize via debugging
> option, and this can cause bad things(tm) to happen when using a file
> system with an inode size of 128 bytes.
> 
> Add better checking when the file system is mounted, as well as when
> we are actually doing the trying to do the inode expansion.
> 
> Reported-by: syzbot+f8d6f8386ceacdbfff57@...kaller.appspotmail.com
> Signed-off-by: Theodore Ts'o <tytso@....edu>
> Cc: stable@...nel.org

Is this patch intended to address
https://lore.kernel.org/linux-ext4/000000000000950f21059564e4c7@google.com
as well?  If so, you can add the second Reported-by line so that both syzbot
reports get closed.

- Eric