lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 19 Nov 2019 13:13:14 -0800 From: Stephen Boyd <sboyd@...nel.org> To: Alan Maguire <alan.maguire@...cle.com>, brendanhiggins@...gle.com, linux-kselftest@...r.kernel.org, skhan@...uxfoundation.org Cc: linux-kernel@...r.kernel.org, kunit-dev@...glegroups.com, keescook@...omium.org, yzaikin@...gle.com, akpm@...ux-foundation.org, yamada.masahiro@...ionext.com, catalin.marinas@....com, joe.lawrence@...hat.com, penguin-kernel@...ove.sakura.ne.jp, schowdary@...dia.com, urezki@...il.com, andriy.shevchenko@...ux.intel.com, corbet@....net, tytso@....edu, adilger.kernel@...ger.ca, mcgrof@...nel.org, changbin.du@...el.com, linux-ext4@...r.kernel.org, linux-doc@...r.kernel.org, Alan Maguire <alan.maguire@...cle.com>, Knut Omang <knut.omang@...cle.com> Subject: Re: [PATCH v4 linux-kselftest-test 5/6] kunit: allow kunit to be loaded as a module Quoting Alan Maguire (2019-11-15 02:16:11) > diff --git a/lib/kunit/test.c b/lib/kunit/test.c > index 87b5cf1..41ef71a 100644 > --- a/lib/kunit/test.c > +++ b/lib/kunit/test.c > @@ -486,3 +486,16 @@ void kunit_cleanup(struct kunit *test) > } > } > EXPORT_SYMBOL_GPL(kunit_cleanup); > + > +static int kunit_init(void) Missing __init? > +{ > + return 0; > +} > +late_initcall(kunit_init); It looks pretty weird that this doesn't do anything in the module init or exit path. How does it work? And why does it need to be late init if nothing is called from here? > + > +static void __exit kunit_exit(void) > +{ > +} > +module_exit(kunit_exit); > + > +MODULE_LICENSE("GPL"); I guess should be "GPL v2"?
Powered by blists - more mailing lists