linux-ext4 - Re: [Resend PATCH] ext2: set proper errno in error case of ext2_fill

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20191129094852.GA1121@quack2.suse.cz>
Date:   Fri, 29 Nov 2019 10:48:52 +0100
From:   Jan Kara <jack@...e.cz>
To:     Chengguang Xu <cgxu519@...ernel.net>
Cc:     jack@...e.com, linux-ext4@...r.kernel.org
Subject: Re: [Resend PATCH] ext2: set proper errno in error case of
 ext2_fill_super()

On Fri 29-11-19 09:36:36, Chengguang Xu wrote:
> Set proper errno in the case of failure of
> initializing percpu variables.
> 
> Signed-off-by: Chengguang Xu <cgxu519@...ernel.net>

Thanks. I've added the patch to my tree.

								Honza

> ---
> Forgot to cc ext4 maillist, so resend it.
> 
>  fs/ext2/super.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/fs/ext2/super.c b/fs/ext2/super.c
> index 30c630d73f0f..74a9e3e71c13 100644
> --- a/fs/ext2/super.c
> +++ b/fs/ext2/super.c
> @@ -1147,6 +1147,7 @@ static int ext2_fill_super(struct super_block *sb, void *data, int silent)
>  				ext2_count_dirs(sb), GFP_KERNEL);
>  	}
>  	if (err) {
> +		ret = err;
>  		ext2_msg(sb, KERN_ERR, "error: insufficient memory");
>  		goto failed_mount3;
>  	}
> -- 
> 2.20.1
> 
> 
> 
-- 
Jan Kara <jack@...e.com>
SUSE Labs, CR