linux-ext4 - Re: e2fsprogs.git dumpe2fs / mke2fs sigserv on sparc64

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CADxRZqzPDfu36TB5ajhtyxrOx2HdPTe-8YE+ZnKA7DkdutUkGw@mail.gmail.com>
Date:   Wed, 18 Dec 2019 03:01:03 +0300
From:   Anatoly Pugachev <matorola@...il.com>
To:     linux-ext4@...r.kernel.org
Subject: Re: e2fsprogs.git dumpe2fs / mke2fs sigserv on sparc64

On Tue, Dec 17, 2019 at 9:01 PM Anatoly Pugachev <matorola@...il.com> wrote:
>
> Hello!
>
> Getting current git e2fsprogs of dumpe2fs/mke2fs (and probably others)
> segfaults (via make check) with the following backtrace:

JFYI

checkout of commit db41ae2c3e4716ceffe212a742d3c963e400fa1e makes
dumpe2fs to work correctly (i.e. not to segfault).
Tried to bisect (not sure it was fully correct, since i don't used
make clean between bisect steps),
marking head as bad and db41ae2c as good, leads to this commit :

e2fsprogs.git$ git bisect good
e6069a05daeb8d18289ad7772d7800b09b418bca is the first bad commit
commit e6069a05daeb8d18289ad7772d7800b09b418bca
Author: Theodore Ts'o <tytso@....edu>
Date:   Tue Oct 22 18:42:25 2019 -0400

    Teach ext2fs_open2() to honor the EXT2_FLAG_SUPER_ONLY flag

    Opening the file system with EXT2_FLAG_SUPER_ONLY will leave
    fs->group_desc to be NULL and modify "dumpe2fs -h" and tune2fs when it
    is emulating e2label to use this flag.  This speeds up "dumpe2fs -h"
    and "e2label" when operating on very large file systems.

    To allow other libext2fs functions to work without too many surprises,
    ext2fs_group_desc() will read in the block group descriptors on
    demand.  This allows "dumpe2fs -h" to be able to read the journal
    inode, for example.

    Signed-off-by: Theodore Ts'o <tytso@....edu>
    Cray-bug-id: LUS-5777

 lib/ext2fs/blknum.c | 39 ++++++++++++++++++++++++++++++++++++---
 lib/ext2fs/openfs.c |  4 +++-
 misc/dumpe2fs.c     |  2 ++
 misc/tune2fs.c      |  2 +-
 4 files changed, 42 insertions(+), 5 deletions(-)


So, if you need BE machine to test on, please use 'gcc compile farm'
BE machines (gcc202 debian sparc64, gcc110 centos-7 ppc64 - and git
master segfaults on gcc110 as well)