linux-ext4 - Re: [PATCH v2] ext4: fix Wunused-but-set-variable warning in ext4_add

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20191222020122.GB63378@mit.edu>
Date:   Sat, 21 Dec 2019 21:01:22 -0500
From:   "Theodore Y. Ts'o" <tytso@....edu>
To:     Yunfeng Ye <yeyunfeng@...wei.com>
Cc:     adilger.kernel@...ger.ca, linux-ext4@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Ritesh Harjani <riteshh@...ux.ibm.com>,
        "hushiyuan@...wei.com" <hushiyuan@...wei.com>,
        "linfeilong@...wei.com" <linfeilong@...wei.com>
Subject: Re: [PATCH v2] ext4: fix Wunused-but-set-variable warning in
 ext4_add_entry()

On Tue, Dec 17, 2019 at 10:46:49PM +0800, Yunfeng Ye wrote:
> Warning is found when compile with "-Wunused-but-set-variable":
> 
> fs/ext4/namei.c: In function ‘ext4_add_entry’:
> fs/ext4/namei.c:2167:23: warning: variable ‘sbi’ set but not used
> [-Wunused-but-set-variable]
>   struct ext4_sb_info *sbi;
>                        ^~~
> Fix this by moving the variable @sbi under CONFIG_UNICODE.
> 
> Signed-off-by: Yunfeng Ye <yeyunfeng@...wei.com>
> Reviewed-by: Ritesh Harjani <riteshh@...ux.ibm.com>

Thanks, applied.

					- Ted