Message-ID: <15817620.rmTN4T87Wr@tauon.chronox.de>
Date:   Fri, 27 Dec 2019 22:22:23 +0100
From:   Stephan Mueller <smueller@...onox.de>
To:     "Theodore Y. Ts'o" <tytso@....edu>
Cc:     Andy Lutomirski <luto@...capital.net>,
        Andy Lutomirski <luto@...nel.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Linux API <linux-api@...r.kernel.org>,
        Kees Cook <keescook@...omium.org>,
        "Jason A. Donenfeld" <Jason@...c4.com>,
        "Ahmed S. Darwish" <darwish.07@...il.com>,
        Lennart Poettering <mzxreary@...inter.de>,
        "Eric W. Biederman" <ebiederm@...ssion.com>,
        "Alexander E. Patrakov" <patrakov@...il.com>,
        Michael Kerrisk <mtk.manpages@...il.com>,
        Willy Tarreau <w@....eu>,
        Matthew Garrett <mjg59@...f.ucam.org>,
        Ext4 Developers List <linux-ext4@...r.kernel.org>,
        linux-man <linux-man@...r.kernel.org>
Subject: Re: [PATCH v3 0/8] Rework random blocking

Am Freitag, 27. Dezember 2019, 14:04:36 CET schrieb Theodore Y. Ts'o:

Hi Theodore,

> On Fri, Dec 27, 2019 at 11:29:22AM +0100, Stephan Mueller wrote:
> > My definition of TRNG is identical to the German AIS 31 and I guess
> > identical to your definition of a TRNG.
> > 
> > A TRNG will produce an amount of random data that is equal to the amount
> > of
> > "fresh" entropy that was provided by the noise source. I.e. it should be
> > identical to the blocking_pool behavior.
> 
> This begs the question of determining: (a) how much "fresh entropy"
> you can actually get from a noise source, (b) at what rate the "fresh
> entropy" is arriving, and (c) what assurance(s) you have that the
> noise source is actually working correctly.
> 
> You can't make those assurances from software alone; it needs to be an
> aspect of holistic design of the hardware's design; the supply chain,
> and the software.  So if we are going to claime that we have something
> like GRND_TRUERANDOM or /dev/trandom, or whatever, it needs to work on
> IOT devices running ARM, RISC-V, MIPS, PowerPC, x86.  Some of these
> architectures have no instruction reordering and are stupid simple;
> some of these hardware platforms may have no high-resolution clock or
> cryptographic instructions.
> 
> In addition, if you use a hardware device which is USB attached, how
> does the kernel know that it really is the device that you think it
> is?  The only way you know that a ChaosKey is a ChaosKey is by its USB
> vendor and product id --- which can be easily forged by an attacker,
> either in the supply chain or delivery path, or who walks up to the
> laptop, yanks out the ChaosKey and replaces it with a "PutinKey" or a
> "NSAKey".
> 
> So creating somethinig which shows up as "true random number
> generator" as a generic Linux concept seems to me to be fraught
> endeavor, and I'm not at all convince people need it.

I am unsure but it sounds like you are refuting your blocking_pool 
implementation. Nothing more and nothing less than the blocking_pool, just 
with a more modern and further analyzed DRNG is what was referenced as a TRNG.

Or maybe the terminology of TRNG (i.e. "true") is offending. I have no concern 
to have it replaced with some other terminology. Yet, I was just taking one 
well-defined term.

Yet, I fully agree that a noise source always must be vetted. This is what I 
tried with random.c in [1], specifically section 6.1 for x86 systems.

For my LRNG, I tried that in [2] section 3.2 compliant to SP800-90B. In order 
to provide a means to everybody to perform such entropy analysis, the entire 
tool set required for it is provided:

- with CONFIG_LRNG_TESTING providing an interface to the raw unconditioned 
noise

- with [3] providing a tool set to gather all data needed for an SP800-90B 
compliant quantitative analysis

Unfortunately due to license restrictions, I cannot make the same tool set 
available used for the quantiative study provided with [1] section 6.1.

Finally, to support the conclusions drawn from a noise source analysis, the 
health tests provided with LRNG compliant to SP800-90B are available with 
CONFIG_LRNG_HEALTH_TESTS. These tests help in identifying weak or broken noise 
sources.

It is fully clear that such studies of non-physical noise sources do not have 
a stochastical model which implies that we cannot make global statements. That 
is the limitation when using such noise sources. Though, the implementation 
should have sufficient "leeway" (i.e. underestmation) when crediting entropy 
to some events.
> 
> > - add a new GRND_TRUERANDOM flag to getrandom(2) which allows access to
> > the
> > TRNG. Andy did not like it because he mentioned that it may be misused
> > since the syscall is unprivileged.
> 
> Even if we could solve the "how the hell can the kernel guarantee that
> the noise source is legitimate" problem in a general way that works
> across all of the architectures, we still have the problem that
> everyone thinks they need "the good stuff".
> 
> Suppose the system call was privileged and "true randomness" could
> only be accessed as root.  What would happen?  Application programmers
> would give instructions requiring that their application be installed
> as root to be more secure, "because that way you can get access the
> _really_ good random numbers".

That is why I think that it is no bug when this interface can DoS other users 
wanting to access the very same resource. This is the price to pay for getting 
access to this type of data.
> 
> So let's take a step back and ask the question: "Exactly what _value_
> do you want to provide by creating some kind of true random
> interface?"  What does this enable?  What applications does this
> really help?

There are simply cryptographers who have use cases for such random numbers. 
The core use case is to seed other DRNGs and avoiding the chaining of free-
running DRNGs.

This is a common approach that you can see in action with the RDSEED 
instruction, for example.
> 
> As I thought while watching the latest Star Wars movie: Why?  Why?
> Whywhywhy?
> 
> 					- Ted

[1] https://www.bsi.bund.de/SharedDocs/Downloads/EN/BSI/Publications/Studies/
LinuxRNG/LinuxRNG_EN.pdf?__blob=publicationFile&v=11

[2] https://chronox.de/lrng/doc/lrng.pdf

[3] https://chronox.de/lrng/lrng-tests-20191123.tar.xz

Ciao
Stephan

Powered by blists - more mailing lists