linux-ext4 - [PATCH] ext4: fix boolreturn.cocci warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 4 Jan 2020 23:04:59 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Daniel Rosenberg <drosen@...gle.com>
Cc:     kbuild-all@...ts.01.org, linux-ext4@...r.kernel.org,
        Theodore Ts'o <tytso@....edu>
Subject: [PATCH] ext4: fix boolreturn.cocci warnings

From: kbuild test robot <lkp@...el.com>

fs/ext4/namei.c:1424:12-13: WARNING: return of 0/1 in function 'ext4_match' with return type bool

 Return statements in functions returning bool should use
 true/false instead of 1/0.
Generated by: scripts/coccinelle/misc/boolreturn.cocci

Fixes: 50d710db6f00 ("ext4: Hande casefolding with encryption")
CC: Daniel Rosenberg <drosen@...gle.com>
Signed-off-by: kbuild test robot <lkp@...el.com>
---

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4.git pu
head:   84df4cb550cf6bfd1d92585fb11736774d07cad5
commit: 50d710db6f001ce37e13efd62b09bd8c0fc593e8 [13/14] ext4: Hande casefolding with encryption

 namei.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/fs/ext4/namei.c
+++ b/fs/ext4/namei.c
@@ -1421,7 +1421,7 @@ static bool ext4_match(struct inode *par
 				if (hinfo.hash != EXT4_DIRENT_HASH(de) ||
 						hinfo.minor_hash !=
 						    EXT4_DIRENT_MINOR_HASH(de))
-					return 0;
+					return false;
 			}
 			return !ext4_ci_compare(parent, &cf, de->name,
 							de->name_len, true);