linux-ext4 - Re: [PATCH -next] ext4: remove unused variable 'mapping'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200107231623.GF472665@magnolia>
Date:   Tue, 7 Jan 2020 15:16:23 -0800
From:   "Darrick J. Wong" <darrick.wong@...cle.com>
To:     YueHaibing <yuehaibing@...wei.com>
Cc:     tytso@....edu, adilger.kernel@...ger.ca, agruenba@...hat.com,
        linux-ext4@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next] ext4: remove unused variable 'mapping'

On Tue, Jan 07, 2020 at 02:23:55PM +0800, YueHaibing wrote:
> fs/ext4/inode.c: In function 'ext4_page_mkwrite':
> fs/ext4/inode.c:5910:24: warning: unused variable 'mapping' [-Wunused-variable]
> 
> commit 4a58d8158f6d ("fs: Fix page_mkwrite off-by-one errors")
> left behind this unused variable.
> 
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>

Er, I had to rebase the branch this morning to remove the f2fs parts
(there's a conflict and they never acked the patch) so I cleaned this up
at the same time.

--D

> ---
>  fs/ext4/inode.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c
> index 9a3e8d0..d0049fd 100644
> --- a/fs/ext4/inode.c
> +++ b/fs/ext4/inode.c
> @@ -5907,7 +5907,6 @@ vm_fault_t ext4_page_mkwrite(struct vm_fault *vmf)
>  	vm_fault_t ret;
>  	struct file *file = vma->vm_file;
>  	struct inode *inode = file_inode(file);
> -	struct address_space *mapping = inode->i_mapping;
>  	handle_t *handle;
>  	get_block_t *get_block;
>  	int retries = 0;
> -- 
> 2.7.4
> 
>