lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 9 Jan 2020 11:22:54 +0100 From: Jan Kara <jack@...e.cz> To: zhengbin <zhengbin13@...wei.com> Cc: tytso@....edu, adilger.kernel@...ger.ca, linux-ext4@...r.kernel.org, yi.zhang@...wei.com Subject: Re: [PATCH] ext4: use true,false for bool variable On Wed 25-12-19 10:45:59, zhengbin wrote: > Fixes coccicheck warning: > > fs/ext4/extents.c:5271:6-12: WARNING: Assignment of 0/1 to bool variable > fs/ext4/extents.c:5287:4-10: WARNING: Assignment of 0/1 to bool variable > > Reported-by: Hulk Robot <hulkci@...wei.com> > Signed-off-by: zhengbin <zhengbin13@...wei.com> Looks good to me. You can add: Reviewed-by: Jan Kara <jack@...e.cz> Honza > --- > fs/ext4/extents.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c > index 0e8708b..d8611be 100644 > --- a/fs/ext4/extents.c > +++ b/fs/ext4/extents.c > @@ -5268,7 +5268,7 @@ ext4_ext_shift_path_extents(struct ext4_ext_path *path, ext4_lblk_t shift, > { > int depth, err = 0; > struct ext4_extent *ex_start, *ex_last; > - bool update = 0; > + bool update = false; > depth = path->p_depth; > > while (depth >= 0) { > @@ -5284,7 +5284,7 @@ ext4_ext_shift_path_extents(struct ext4_ext_path *path, ext4_lblk_t shift, > goto out; > > if (ex_start == EXT_FIRST_EXTENT(path[depth].p_hdr)) > - update = 1; > + update = true; > > while (ex_start <= ex_last) { > if (SHIFT == SHIFT_LEFT) { > -- > 2.7.4 > -- Jan Kara <jack@...e.com> SUSE Labs, CR
Powered by blists - more mailing lists