lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 13 Jan 2020 14:25:08 -0500 From: "Theodore Y. Ts'o" <tytso@....edu> To: Eric Biggers <ebiggers@...nel.org> Cc: linux-ext4@...r.kernel.org, linux-fscrypt@...r.kernel.org Subject: Re: [PATCH] ext4: handle decryption error in __ext4_block_zero_page_range() On Thu, Dec 26, 2019 at 09:41:05AM -0600, Eric Biggers wrote: > From: Eric Biggers <ebiggers@...gle.com> > > fscrypt_decrypt_pagecache_blocks() can fail, because it uses > skcipher_request_alloc(), which uses kmalloc(), which can fail; and also > because it calls crypto_skcipher_decrypt(), which can fail depending on > the driver that actually implements the crypto. > > Therefore it's not appropriate to WARN on decryption error in > __ext4_block_zero_page_range(). > > Remove the WARN and just handle the error instead. > > Signed-off-by: Eric Biggers <ebiggers@...gle.com> Thanks, applied. - Ted
Powered by blists - more mailing lists