linux-ext4 - Re: [PATCH] fscrypt: optimize fscrypt_zeroout

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200113193109.GB76141@mit.edu>
Date:   Mon, 13 Jan 2020 14:31:09 -0500
From:   "Theodore Y. Ts'o" <tytso@....edu>
To:     Eric Biggers <ebiggers@...nel.org>
Cc:     linux-fscrypt@...r.kernel.org, linux-ext4@...r.kernel.org
Subject: Re: [PATCH] fscrypt: optimize fscrypt_zeroout_range()

On Thu, Dec 26, 2019 at 10:08:13AM -0600, Eric Biggers wrote:
> From: Eric Biggers <ebiggers@...gle.com>
> 
> Currently fscrypt_zeroout_range() issues and waits on a bio for each
> block it writes, which makes it very slow.
> 
> Optimize it to write up to 16 pages at a time instead.
> 
> Also add a function comment, and improve reliability by allowing the
> allocations of the bio and the first ciphertext page to wait on the
> corresponding mempools.
> 
> Signed-off-by: Eric Biggers <ebiggers@...gle.com>

Looks good, feel free to add:

Reviewed-by: Theodore Ts'o <tytso@....edu>