linux-ext4 - Re: [PATCH] ext4,jbd2: fix comment and code style

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 22 Jan 2020 09:47:02 +0100
From:   Jan Kara <jack@...e.cz>
To:     Shijie Luo <luoshijie1@...wei.com>
Cc:     linux-ext4@...r.kernel.org, tytso@....edu, jack@...e.cz
Subject: Re: [PATCH] ext4,jbd2: fix comment and code style

On Wed 22-01-20 02:26:25, Shijie Luo wrote:
> Fix comment and remove unnecessary blank.
> 
> Signed-off-by: Shijie Luo <luoshijie1@...wei.com>

Looks good. You can add:

Reviewed-by: Jan Kara <jack@...e.cz>

								Honza

> ---
>  fs/ext4/inline.c      | 2 +-
>  fs/jbd2/transaction.c | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/fs/ext4/inline.c b/fs/ext4/inline.c
> index 2fec62d764fa..a6695e1d246c 100644
> --- a/fs/ext4/inline.c
> +++ b/fs/ext4/inline.c
> @@ -849,7 +849,7 @@ static int ext4_da_convert_inline_data_to_extent(struct address_space *mapping,
>  
>  /*
>   * Prepare the write for the inline data.
> - * If the the data can be written into the inode, we just read
> + * If the data can be written into the inode, we just read
>   * the page and make it uptodate, and start the journal.
>   * Otherwise read the page, makes it dirty so that it can be
>   * handle in writepages(the i_disksize update is left to the
> diff --git a/fs/jbd2/transaction.c b/fs/jbd2/transaction.c
> index 27b9f9dee434..f7a9da75b160 100644
> --- a/fs/jbd2/transaction.c
> +++ b/fs/jbd2/transaction.c
> @@ -1595,7 +1595,7 @@ int jbd2_journal_dirty_metadata(handle_t *handle, struct buffer_head *bh)
>   * Allow this call even if the handle has aborted --- it may be part of
>   * the caller's cleanup after an abort.
>   */
> -int jbd2_journal_forget (handle_t *handle, struct buffer_head *bh)
> +int jbd2_journal_forget(handle_t *handle, struct buffer_head *bh)
>  {
>  	transaction_t *transaction = handle->h_transaction;
>  	journal_t *journal;
> -- 
> 2.19.1
> 
-- 
Jan Kara <jack@...e.com>
SUSE Labs, CR