linux-ext4 - Re: [PATCH 1/2] mmp: don't assume NUL termination for MMP strings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200125064344.GA1108497@mit.edu>
Date:   Sat, 25 Jan 2020 01:43:44 -0500
From:   "Theodore Y. Ts'o" <tytso@....edu>
To:     Andreas Dilger <adilger@...ger.ca>
Cc:     linux-ext4@...r.kernel.org
Subject: Re: [PATCH 1/2] mmp: don't assume NUL termination for MMP strings

On Tue, Jan 14, 2020 at 02:42:17PM -0700, Andreas Dilger wrote:
> Don't assume that mmp_nodename and mmp_bdevname are NUL terminated,
> since very long node/device names may completely fill the buffers.
> 
> Limit string printing to the maximum buffer size for safety, and
> change the field definitions to __u8 to make it more clear that
> they are not NUL-terminated strings, as is done with other strings
> in the superblock that do not have NUL termination.
> 
> Signed-off-by: Andreas Dilger <adilger@...ger.ca>

Applied, thanks.

					- Ted