lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 25 Jan 2020 02:03:18 -0500 From: "Theodore Y. Ts'o" <tytso@....edu> To: Dmitry Monakhov <dmonakhov@...il.com> Cc: linux-ext4@...r.kernel.org, darrick.wong@...cle.com Subject: Re: [PATCH 1/2] ext4: fix symbolic enum printing in trace output On Thu, Nov 14, 2019 at 08:01:46PM +0000, Dmitry Monakhov wrote: > Trace's macro __print_flags() produce raw event's decraration w/o knowing actual > flags value > > cat /sys/kernel/debug/tracing/events/ext4/ext4_ext_map_blocks_exit/format > .. > __print_flags(REC->mflags, "", { (1 << BH_New), > > For that reason we have to explicitly define it via special macro TRACE_DEFINE_ENUM() > Also add missed EXTENT_STATUS_REFERENCED flag. > > #Before patch > ext4:ext4_ext_map_blocks_exit: dev 253,0 ino 2 flags lblk 0 pblk 4177 len 1 mflags 0x20 ret 1 > ext4:ext4_ext_map_blocks_exit: dev 253,0 ino 12 flags CREATE lblk 0 pblk 34304 len 1 mflags 0x60 ret 1 > > #With patch > ext4:ext4_ext_map_blocks_exit: dev 253,0 ino 2 flags lblk 0 pblk 4177 len 1 mflags M ret 1 > ext4:ext4_ext_map_blocks_exit: dev 253,0 ino 12 flags CREATE lblk 0 pblk 34816 len 1 mflags NM ret 1 > > Signed-off-by: Dmitry Monakhov <dmonakhov@...il.com> Thanks, applied. - Ted
Powered by blists - more mailing lists