linux-ext4 - Re: [PATCH] ext4: delete declaration for ext4_split

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200212170236.GA6863@magnolia>
Date:   Wed, 12 Feb 2020 09:02:36 -0800
From:   "Darrick J. Wong" <darrick.wong@...cle.com>
To:     Eric Whitney <enwlinux@...il.com>
Cc:     linux-ext4@...r.kernel.org, tytso@....edu
Subject: Re: [PATCH] ext4:  delete declaration for ext4_split_extent()

On Wed, Feb 12, 2020 at 11:21:41AM -0500, Eric Whitney wrote:
> There are no forward references for ext4_split_extent() in extents.c,
> so delete its unnecessary declaration.
> 
> Signed-off-by: Eric Whitney <enwlinux@...il.com>

Looks good to me,
Reviewed-by: Darrick J. Wong <darrick.wong@...cle.com>

--D

> ---
>  fs/ext4/extents.c | 7 -------
>  1 file changed, 7 deletions(-)
> 
> diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c
> index 89aa9c7ae293..a5338a8da2ab 100644
> --- a/fs/ext4/extents.c
> +++ b/fs/ext4/extents.c
> @@ -83,13 +83,6 @@ static void ext4_extent_block_csum_set(struct inode *inode,
>  	et->et_checksum = ext4_extent_block_csum(inode, eh);
>  }
>  
> -static int ext4_split_extent(handle_t *handle,
> -				struct inode *inode,
> -				struct ext4_ext_path **ppath,
> -				struct ext4_map_blocks *map,
> -				int split_flag,
> -				int flags);
> -
>  static int ext4_split_extent_at(handle_t *handle,
>  			     struct inode *inode,
>  			     struct ext4_ext_path **ppath,
> -- 
> 2.11.0
>