linux-ext4 - Re: [PATCH RFC] ext4: fix potential race between online resizing and write operations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200216203258.GE566898@mit.edu>
Date:   Sun, 16 Feb 2020 15:32:58 -0500
From:   "Theodore Y. Ts'o" <tytso@....edu>
To:     "Paul E. McKenney" <paulmck@...nel.org>
Cc:     Ext4 Developers List <linux-ext4@...r.kernel.org>,
        Suraj Jitindar Singh <surajjs@...zon.com>,
        Uladzislau Rezki <urezki@...il.com>,
        Joel Fernandes <joel@...lfernandes.org>
Subject: Re: [PATCH RFC] ext4: fix potential race between online resizing and
 write operations

On Sun, Feb 16, 2020 at 04:12:46AM -0800, Paul E. McKenney wrote:
> > +void ext4_kvfree_array_rcu(void *to_free)
> > +{
> > +	struct ext4_rcu_ptr *ptr = kzalloc(sizeof(*ptr), GFP_KERNEL);
> > +
> > +	if (ptr) {
> > +		ptr->ptr = to_free;
> > +		call_rcu(&ptr->rcu, ext4_rcu_ptr_callback);
> > +		return;
> > +	}
> > +	synchronize_rcu();
> > +	kvfree(ptr);
> > +}

Whoops, that last statement should be kvfree(to_free), of course.
I'll fix that up in my tree.

		     	      	       - Ted