lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 18 Feb 2020 19:28:26 -0800 From: Eric Biggers <ebiggers@...nel.org> To: Matthew Wilcox <willy@...radead.org> Cc: linux-fsdevel@...r.kernel.org, linux-xfs@...r.kernel.org, Junxiao Bi <junxiao.bi@...cle.com>, linux-kernel@...r.kernel.org, linux-f2fs-devel@...ts.sourceforge.net, cluster-devel@...hat.com, linux-mm@...ck.org, ocfs2-devel@....oracle.com, linux-ext4@...r.kernel.org, linux-erofs@...ts.ozlabs.org, linux-btrfs@...r.kernel.org Subject: Re: [PATCH v6 10/19] fs: Convert mpage_readpages to mpage_readahead On Mon, Feb 17, 2020 at 10:45:58AM -0800, Matthew Wilcox wrote: > diff --git a/include/linux/mpage.h b/include/linux/mpage.h > index 001f1fcf9836..f4f5e90a6844 100644 > --- a/include/linux/mpage.h > +++ b/include/linux/mpage.h > @@ -13,9 +13,9 @@ > #ifdef CONFIG_BLOCK > > struct writeback_control; > +struct readahead_control; > > -int mpage_readpages(struct address_space *mapping, struct list_head *pages, > - unsigned nr_pages, get_block_t get_block); > +void mpage_readahead(struct readahead_control *, get_block_t get_block); > int mpage_readpage(struct page *page, get_block_t get_block); > int mpage_writepages(struct address_space *mapping, > struct writeback_control *wbc, get_block_t get_block); Can you name the 'struct readahead_control *' parameter? checkpatch.pl should warn about this. - Eric
Powered by blists - more mailing lists