linux-ext4 - [PATCH v3 0/2] ext4: fix race between writepages and enabling EXT4_EXTENTS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20200219183047.47417-1-ebiggers@kernel.org>
Date:   Wed, 19 Feb 2020 10:30:45 -0800
From:   Eric Biggers <ebiggers@...nel.org>
To:     linux-ext4@...r.kernel.org, Theodore Ts'o <tytso@....edu>
Cc:     Jan Kara <jack@...e.cz>
Subject: [PATCH v3 0/2] ext4: fix race between writepages and enabling EXT4_EXTENTS_FL

This series fixes a race between writepages and enabling EXT4_EXTENTS_FL
that could cause a WARN_ON() in ext4_add_complete_io() to be hit.  Patch
1 is a trivial renaming in preparation for patch 2 which is the actual
fix.  See patch 2 for the full details.

Changed in v3:
    Do the renaming in a separate patch.

Changed in v2:
    Instead of making ext4_writepages() read EXT4_EXTENTS_FL only once,
    make it so that EXT4_EXTENTS_FL can't be changed while
    ext4_writepages() is running.

Eric Biggers (2):
  ext4: rename s_journal_flag_rwsem to s_writepages_rwsem
  ext4: fix race between writepages and enabling EXT4_EXTENTS_FL

 fs/ext4/ext4.h    |  7 +++++--
 fs/ext4/inode.c   | 14 +++++++-------
 fs/ext4/migrate.c | 27 +++++++++++++++++++--------
 fs/ext4/super.c   |  6 +++---
 4 files changed, 34 insertions(+), 20 deletions(-)


base-commit: c96dceeabf765d0b1b1f29c3bf50a5c01315b820
-- 
2.25.0