linux-ext4 - Re: [PATCH 1/3] ext4: introduce macro sbi_array_rcu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200220050431.GE476845@mit.edu>
Date:   Thu, 20 Feb 2020 00:04:31 -0500
From:   "Theodore Y. Ts'o" <tytso@....edu>
To:     Suraj Jitindar Singh <surajjs@...zon.com>
Cc:     linux-ext4@...r.kernel.org, sblbir@...zon.com,
        sjitindarsingh@...il.com, stable@...r-kernel.org
Subject: Re: [PATCH 1/3] ext4: introduce macro sbi_array_rcu_deref() to
 access rcu protected fields

On Tue, Feb 18, 2020 at 07:08:49PM -0800, Suraj Jitindar Singh wrote:
> The s_group_desc field in the super block info (sbi) is protected by rcu to
> prevent access to an invalid pointer during online resize operations.
> There are 2 other arrays in sbi, s_group_info and s_flex_groups, which
> require similar rcu protection which is introduced in the subsequent
> patches. Introduce a helper macro sbi_array_rcu_deref() to be used to
> provide rcu protected access to such fields.
> 
> Also update the current s_group_desc access site to use the macro.
> 
> Signed-off-by: Suraj Jitindar Singh <surajjs@...zon.com>
> Cc: stable@...r-kernel.org

Thanks, applied with the simplification suggested by Balbir.  Also
note that I generally use stable@...nel.org instead of
stable@...r.kernel.org, since that avoids sending excess mail to
stable@...r.kernel.org mailing list.  (The stable kernel scripts look
for stable@...nel.org as well as stable@...r.kernel.org.)  I've made
that change in the version of the patch that I applied.

	     	       	   	      	  - Ted