linux-ext4 - Re: [PATCH 02/21] block: remove _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200313141938.GD225435@mit.edu>
Date:   Fri, 13 Mar 2020 10:19:38 -0400
From:   "Theodore Y. Ts'o" <tytso@....edu>
To:     Christoph Hellwig <hch@....de>
Cc:     Jens Axboe <axboe@...nel.dk>, linux-block@...r.kernel.org,
        linux-raid@...r.kernel.org, linux-scsi@...r.kernel.org,
        linux-ext4@...r.kernel.org, reiserfs-devel@...r.kernel.org
Subject: Re: [PATCH 02/21] block: remove __bdevname

On Thu, Mar 12, 2020 at 04:19:20PM +0100, Christoph Hellwig wrote:
> There is no good reason for __bdevname to exist.  Just open code
> printing the string in the callers.  For three of them the format
> string can be trivially merged into existing printk statements,
> and in init/do_mounts.c we can at least do the scnprintf once at
> the start of the function, and unconditional of CONFIG_BLOCK to
> make the output for tiny configfs a little more helpful.
> 
> Signed-off-by: Christoph Hellwig <hch@....de>

Acked-by: Theodore Ts'o <tytso@....edu> # for ext4