linux-ext4 - Re: [PATCH] ext2: fix debug reference to ext2_xattr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9b4e1fa7-b4f8-b2a9-8269-04daeb3dfaaa@infradead.org>
Date:   Tue, 17 Mar 2020 08:19:48 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Jan Kara <jack@...e.cz>
Cc:     Linux FS Devel <linux-fsdevel@...r.kernel.org>,
        linux-ext4@...r.kernel.org, Jan Kara <jack@...e.com>,
        Al Viro <viro@...iv.linux.org.uk>
Subject: Re: [PATCH] ext2: fix debug reference to ext2_xattr_cache

On 3/17/20 4:47 AM, Jan Kara wrote:
> On Fri 13-03-20 20:42:05, Randy Dunlap wrote:
>> From: Randy Dunlap <rdunlap@...radead.org>
>>
>> Fix a debug-only build error in ext2/xattr.c:
>>
>> When building without extra debugging, (and with another patch that uses
>> no_printk() instead of <empty> for the ext2-xattr debug-print macros,
>> this build error happens:
>>
>> ../fs/ext2/xattr.c: In function ‘ext2_xattr_cache_insert’:
>> ../fs/ext2/xattr.c:869:18: error: ‘ext2_xattr_cache’ undeclared (first use in this function); did you mean ‘ext2_xattr_list’?
>>      atomic_read(&ext2_xattr_cache->c_entry_count));
>>
>> Fix by moving struct mb_cache from fs/mbcache.c to <linux/mbcache.h>,
>> and then using the correct struct name in the debug-print macro.
>>
>> This wasn't converted when ext2 xattr cache was changed to use mbcache.
>>
>> Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
>> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
>> Cc: Jan Kara <jack@...e.com>
>> Cc: Alexander Viro <viro@...iv.linux.org.uk>
>> Cc: linux-ext4@...r.kernel.org
>> Cc: linux-fsdevel@...r.kernel.org
> 
> Thanks for the patch! I don't think exporting 'struct mb_cache' just for
> this is reasonable. I've committed a patch which just removes the entry
> count from the debug message (attached).
> 

Sure, that's good.  I have a patch like that one on my system also. :)

> 
>> ---
>> This is ancient, from the beginning of git history.
>>
>> Or just kill of that print of c_entry_count...
>>
>>  fs/ext2/xattr.c         |    2 +-
>>  fs/mbcache.c            |   34 ----------------------------------
>>  include/linux/mbcache.h |   35 ++++++++++++++++++++++++++++++++++-
>>  3 files changed, 35 insertions(+), 36 deletions(-)

-- 
~Randy