linux-ext4 - Re: [PATCH] ext4: do not commit super on read-only bdev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 18 Mar 2020 16:09:11 -0600
From:   Andreas Dilger <adilger@...ger.ca>
To:     Eric Sandeen <sandeen@...deen.net>
Cc:     "linux-ext4@...r.kernel.org" <linux-ext4@...r.kernel.org>,
        Ritesh Harjani <riteshh@...ux.ibm.com>
Subject: Re: [PATCH] ext4: do not commit super on read-only bdev

On Mar 18, 2020, at 1:19 PM, Eric Sandeen <sandeen@...deen.net> wrote:
> 
> From: Eric Sandeen <sandeen@...hat.com>
> 
> Under some circumstances we may encounter a filesystem error on a
> read-only block device, and if we try to save the error info to the
> superblock and commit it, we'll wind up with a noisy error and
> backtrace, i.e.:
> 
> [ 3337.146838] EXT4-fs error (device pmem1p2): ext4_get_journal_inode:4634: comm mount: inode #0: comm mount: iget: illegal inode #
> ------------[ cut here ]------------
> generic_make_request: Trying to write to read-only block-device pmem1p2 (partno 2)
> WARNING: CPU: 107 PID: 115347 at block/blk-core.c:788 generic_make_request_checks+0x6b4/0x7d0
> ...
> 
> To avoid this, commit the error info in the superblock only if the
> block device is writable.
> 
> Reported-by: Ritesh Harjani <riteshh@...ux.ibm.com>
> Signed-off-by: Eric Sandeen <sandeen@...hat.com>

Reviewed-by: Andreas Dilger <adilger@...ger.ca>

> ---
> 
> (compile-tested only FWIW)
> (also, not sure if the bdev test in __save_error_info should be removed?)
> 
> diff --git a/fs/ext4/super.c b/fs/ext4/super.c
> index 0c7c4adb664e..55392903bda5 100644
> --- a/fs/ext4/super.c
> +++ b/fs/ext4/super.c
> @@ -372,7 +372,8 @@ static void save_error_info(struct super_block *sb, const char *func,
> 			    unsigned int line)
> {
> 	__save_error_info(sb, func, line);
> -	ext4_commit_super(sb, 1);
> +	if (!bdev_read_only(sb->s_bdev))
> +		ext4_commit_super(sb, 1);
> }
> 
> /*


Cheers, Andreas






Download attachment "signature.asc" of type "application/pgp-signature" (874 bytes)