linux-ext4 - Re: [f2fs-dev] Fwd: Add page_cache_readahead

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200320154947.GA851@sol.localdomain>
Date:   Fri, 20 Mar 2020 08:49:47 -0700
From:   Eric Biggers <ebiggers@...nel.org>
To:     Matthew Wilcox <willy@...radead.org>
Cc:     linux-ext4@...r.kernel.org, linux-f2fs-devel@...ts.sourceforge.net,
        Theodore Ts'o <tytso@....edu>,
        Jaegeuk Kim <jaegeuk@...nel.org>, Chao Yu <yuchao0@...wei.com>
Subject: Re: [f2fs-dev] Fwd: Add page_cache_readahead_unbounded

Hi Matthew,

On Fri, Mar 20, 2020 at 07:29:32AM -0700, Matthew Wilcox wrote:
> 
> I'm a little disappointed to have received no feedback on these patches
> from those who were involved with creating the ugly situation in the
> first place.
> 
> There are other ext4/f2fs patches in this patch series for which it
> would also be nice to get reviewed-by tags.
> 
> ----- Forwarded message from Matthew Wilcox <willy@...radead.org> -----
> 
> Date: Fri, 20 Mar 2020 07:22:19 -0700
> From: Matthew Wilcox <willy@...radead.org>
> To: Andrew Morton <akpm@...ux-foundation.org>
> Cc: "Matthew Wilcox (Oracle)" <willy@...radead.org>,
> 	linux-fsdevel@...r.kernel.org, linux-mm@...ck.org,
> 	linux-kernel@...r.kernel.org, linux-btrfs@...r.kernel.org,
> 	linux-erofs@...ts.ozlabs.org, linux-ext4@...r.kernel.org,
> 	linux-f2fs-devel@...ts.sourceforge.net, cluster-devel@...hat.com,
> 	ocfs2-devel@....oracle.com, linux-xfs@...r.kernel.org, Christoph
> 	Hellwig <hch@....de>, William Kucharski <william.kucharski@...cle.com>
> Subject: [PATCH v9 13/25] mm: Add page_cache_readahead_unbounded
> X-Mailer: git-send-email 2.21.1
> 
> From: "Matthew Wilcox (Oracle)" <willy@...radead.org>
> 
> ext4 and f2fs have duplicated the guts of the readahead code so
> they can read past i_size.  Instead, separate out the guts of the
> readahead code so they can call it directly.
> 
> Signed-off-by: Matthew Wilcox (Oracle) <willy@...radead.org>
> Reviewed-by: Christoph Hellwig <hch@....de>
> Reviewed-by: William Kucharski <william.kucharski@...cle.com>

I actually did look at this patch last month and it looked fine.  Thanks for
doing this.

To be clear, we'd be fine with maintaining filesystem-specific code that does
the setup necessary to call ext4_mpage_readpages() and f2fs_mpage_readpages()
properly.  And that was the original intent, so that nothing would leak into the
VFS.  But I understand that the new readahead calling convention is different
and a bit more complex, and it's annoying to have multiple callers.  So if
page_cache_readahead_unbounded() makes things easier for you, it's fine with me.

I'll take a closer look at your v9 series today and provide Reviewed-by on this
patch and others.  Sorry for not doing so earlier.

Thanks!

- Eric