linux-ext4 - Re: [PATCH] ext4: Unregister sysfs path before destroying jbd2 journal

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200326145311.GR53396@mit.edu>
Date:   Thu, 26 Mar 2020 10:53:11 -0400
From:   "Theodore Y. Ts'o" <tytso@....edu>
To:     Jan Kara <jack@...e.cz>
Cc:     Ritesh Harjani <riteshh@...ux.ibm.com>, linux-ext4@...r.kernel.org,
        adilger.kernel@...ger.ca, linux-fsdevel@...r.kernel.org
Subject: Re: [PATCH] ext4: Unregister sysfs path before destroying jbd2
 journal

On Wed, Mar 18, 2020 at 10:13:18AM +0100, Jan Kara wrote:
> On Wed 18-03-20 11:43:01, Ritesh Harjani wrote:
> > Call ext4_unregister_sysfs(), before destroying jbd2 journal,
> > since below might cause, NULL pointer dereference issue.
> > This got reported with LTP tests.
> > 
> > ext4_put_super() 		cat /sys/fs/ext4/loop2/journal_task
> > 	| 				ext4_attr_show();
> > ext4_jbd2_journal_destroy();  			|
> >     	|				 journal_task_show()
> > 	| 					|
> > 	| 				task_pid_vnr(NULL);
> > sbi->s_journal = NULL;
> > 
> > Signed-off-by: Ritesh Harjani <riteshh@...ux.ibm.com>
> 
> Yeah, makes sence. Thanks for the patch! You can add:
> 
> Reviewed-by: Jan Kara <jack@...e.cz>

Applied, thanks.

					- Ted