linux-ext4 - Re: [PATCH] ext4: Fix incorrect inodes per group in error message

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <AD34FA78-D061-44E7-96BC-907B51AB75BD@dilger.ca>
Date:   Sat, 28 Mar 2020 16:57:06 -0600
From:   Andreas Dilger <adilger@...ger.ca>
To:     Josh Triplett <josh@...htriplett.org>
Cc:     linux-ext4 <linux-ext4@...r.kernel.org>,
        linux-kernel@...r.kernel.org, Theodore Ts'o <tytso@....edu>,
        Andreas Dilger <adilger.kernel@...ger.ca>
Subject: Re: [PATCH] ext4: Fix incorrect inodes per group in error message

On Mar 28, 2020, at 4:34 PM, Josh Triplett <josh@...htriplett.org> wrote:
> 
> If ext4_fill_super detects an invalid number of inodes per group, the
> resulting error message printed the number of blocks per group, rather
> than the number of inodes per group. Fix it to print the correct value.
> 
> Signed-off-by: Josh Triplett <josh@...htriplett.org>
> Fixes: cd6bb35bf7f6d ("ext4: use more strict checks for inodes_per_block on mount")

LGTM

Reviewed-by: Andreas Dilger <adilger@...ger.ca>

> ---
> fs/ext4/super.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/ext4/super.c b/fs/ext4/super.c
> index 0c7c4adb664e..c50922fa780a 100644
> --- a/fs/ext4/super.c
> +++ b/fs/ext4/super.c
> @@ -4157,7 +4157,7 @@ static int ext4_fill_super(struct super_block *sb, void *data, int silent)
> 	if (sbi->s_inodes_per_group < sbi->s_inodes_per_block ||
> 	    sbi->s_inodes_per_group > blocksize * 8) {
> 		ext4_msg(sb, KERN_ERR, "invalid inodes per group: %lu\n",
> -			 sbi->s_blocks_per_group);
> +			 sbi->s_inodes_per_group);
> 		goto failed_mount;
> 	}
> 	sbi->s_itb_per_group = sbi->s_inodes_per_group /
> --
> 2.26.0
> 


Cheers, Andreas






Download attachment "signature.asc" of type "application/pgp-signature" (874 bytes)