linux-ext4 - Re: [PATCH] ext4: remove unnecessary test_opt for DIOREAD

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20200413043813.4FA0F4C058@d06av22.portsmouth.uk.ibm.com>
Date:   Mon, 13 Apr 2020 10:08:12 +0530
From:   Ritesh Harjani <riteshh@...ux.ibm.com>
To:     xiakaixu1987@...il.com, linux-ext4@...r.kernel.org
Cc:     tytso@....edu, adilger.kernel@...ger.ca,
        Kaixu Xia <kaixuxia@...cent.com>
Subject: Re: [PATCH] ext4: remove unnecessary test_opt for DIOREAD_NOLOCK



On 4/13/20 9:54 AM, xiakaixu1987@...il.com wrote:
> From: Kaixu Xia <kaixuxia@...cent.com>
> 
> The DIOREAD_NOLOCK flag has been cleared when doing the test_opt
> that is meaningless, so remove the unnecessary test_opt for DIOREAD_NOLOCK.
> 
> Signed-off-by: Kaixu Xia <kaixuxia@...cent.com>

Make sense.
Reviewed-by: Ritesh Harjani <riteshh@...ux.ibm.com>


> ---
>   fs/ext4/super.c | 6 +-----
>   1 file changed, 1 insertion(+), 5 deletions(-)
> 
> diff --git a/fs/ext4/super.c b/fs/ext4/super.c
> index 9728e7b0e84f..855874ea4b29 100644
> --- a/fs/ext4/super.c
> +++ b/fs/ext4/super.c
> @@ -3973,17 +3973,13 @@ static int ext4_fill_super(struct super_block *sb, void *data, int silent)
> 
>   	if (test_opt(sb, DATA_FLAGS) == EXT4_MOUNT_JOURNAL_DATA) {
>   		printk_once(KERN_WARNING "EXT4-fs: Warning: mounting with data=journal disables delayed allocation, dioread_nolock, and O_DIRECT support!\n");
> +		/* can't mount with both data=journal and dioread_nolock. */
>   		clear_opt(sb, DIOREAD_NOLOCK);
>   		if (test_opt2(sb, EXPLICIT_DELALLOC)) {
>   			ext4_msg(sb, KERN_ERR, "can't mount with "
>   				 "both data=journal and delalloc");
>   			goto failed_mount;
>   		}
> -		if (test_opt(sb, DIOREAD_NOLOCK)) {
> -			ext4_msg(sb, KERN_ERR, "can't mount with "
> -				 "both data=journal and dioread_nolock");
> -			goto failed_mount;
> -		}
>   		if (test_opt(sb, DAX)) {
>   			ext4_msg(sb, KERN_ERR, "can't mount with "
>   				 "both data=journal and dax");
>