[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAOQ4uxg2KOVBxqF400KW3VaQEaX4JGqfb_vCW=esTMkJqZWwvA@mail.gmail.com>
Date: Sat, 25 Apr 2020 13:49:43 +0300
From: Amir Goldstein <amir73il@...il.com>
To: Christoph Hellwig <hch@...radead.org>
Cc: Ritesh Harjani <riteshh@...ux.ibm.com>,
Ext4 <linux-ext4@...r.kernel.org>, Jan Kara <jack@...e.cz>,
Theodore Tso <tytso@....edu>,
Andreas Dilger <adilger@...ger.ca>,
"Darrick J. Wong" <darrick.wong@...cle.com>,
Alexander Viro <viro@...iv.linux.org.uk>,
Dan Carpenter <dan.carpenter@...cle.com>,
"Aneesh Kumar K . V" <aneesh.kumar@...ux.ibm.com>,
Murphy Zhou <jencce.kernel@...il.com>,
Miklos Szeredi <miklos@...redi.hu>,
linux-fsdevel <linux-fsdevel@...r.kernel.org>,
overlayfs <linux-unionfs@...r.kernel.org>
Subject: Re: [PATCH 0/5] ext4/overlayfs: fiemap related fixes
On Sat, Apr 25, 2020 at 12:43 PM Christoph Hellwig <hch@...radead.org> wrote:
>
> On Sat, Apr 25, 2020 at 12:11:59PM +0300, Amir Goldstein wrote:
> > FWIW, I agree with you.
> > And seems like Jan does as well, since he ACKed all your patches.
> > Current patches would be easier to backport to stable kernels.
>
> Honestly, the proper fix is pretty much trivial. I wrote it up this
> morning over coffee:
>
> http://git.infradead.org/users/hch/misc.git/shortlog/refs/heads/fiemap-fix
>
> Still needs more testing, though.
Very slick!
I still think Ritesh's patches are easier for backporting because they are
mostly contained within the ext4/overlayfs subsystems and your patch
can follow up as interface cleanup.
I would use as generic helper name generic_fiemap_checks()
akin to generic_write_checks() and generic_remap_file_range_prep() =>
generic_remap_checks().
Thanks,
Amir.
Powered by blists - more mailing lists