lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20200427103854.GA30463@infradead.org> Date: Mon, 27 Apr 2020 03:38:54 -0700 From: Christoph Hellwig <hch@...radead.org> To: Amir Goldstein <amir73il@...il.com> Cc: Christoph Hellwig <hch@...radead.org>, Ritesh Harjani <riteshh@...ux.ibm.com>, Ext4 <linux-ext4@...r.kernel.org>, Jan Kara <jack@...e.cz>, Theodore Tso <tytso@....edu>, Andreas Dilger <adilger@...ger.ca>, "Darrick J. Wong" <darrick.wong@...cle.com>, Alexander Viro <viro@...iv.linux.org.uk>, Dan Carpenter <dan.carpenter@...cle.com>, "Aneesh Kumar K . V" <aneesh.kumar@...ux.ibm.com>, Murphy Zhou <jencce.kernel@...il.com>, Miklos Szeredi <miklos@...redi.hu>, linux-fsdevel <linux-fsdevel@...r.kernel.org>, overlayfs <linux-unionfs@...r.kernel.org> Subject: Re: [PATCH 0/5] ext4/overlayfs: fiemap related fixes On Mon, Apr 27, 2020 at 01:15:22PM +0300, Amir Goldstein wrote: > On Mon, Apr 27, 2020 at 9:28 AM Christoph Hellwig <hch@...radead.org> wrote: > > > > On Sat, Apr 25, 2020 at 01:49:43PM +0300, Amir Goldstein wrote: > > > I would use as generic helper name generic_fiemap_checks() > > > akin to generic_write_checks() and generic_remap_file_range_prep() => > > > generic_remap_checks(). > > > > None of the other fiemap helpers use the redundant generic_ prefix. > > Fine. I still don't like the name _validate() so much because it implies > yes or no, not length truncating. > > What's more, if we decide that FIEMAP_FLAG_SYNC handling should > be done inside this generic helper, we would definitely need to rename it > again. So how about going for something a bit more abstract like > fiemap_prep() or whatever. Ok, I'll rename it to fiemap_prep. > > What is your take about FIEMAP_FLAG_SYNC handling btw? Oh, I hadn't really noticed that mess. Taking it into fiemap_prep might make most sense, so that it nominally is under fs control for e.g. locking purposes.
Powered by blists - more mailing lists