linux-ext4 - Re: [PATCH 09/11] fs: handle FIEMAP_FLAG_SYNC in fiemap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOQ4uxj8=C887JUSEMDZtyUz+m9muVUd1Z4o64RX1pH8LJYrkw@mail.gmail.com>
Date:   Tue, 28 Apr 2020 05:26:07 +0300
From:   Amir Goldstein <amir73il@...il.com>
To:     Christoph Hellwig <hch@....de>
Cc:     Ext4 <linux-ext4@...r.kernel.org>,
        Al Viro <viro@...iv.linux.org.uk>, Jan Kara <jack@...e.cz>,
        Theodore Tso <tytso@....edu>,
        Andreas Dilger <adilger@...ger.ca>,
        Ritesh Harjani <riteshh@...ux.ibm.com>,
        linux-fsdevel <linux-fsdevel@...r.kernel.org>,
        overlayfs <linux-unionfs@...r.kernel.org>
Subject: Re: [PATCH 09/11] fs: handle FIEMAP_FLAG_SYNC in fiemap_prep

On Mon, Apr 27, 2020 at 9:20 PM Christoph Hellwig <hch@....de> wrote:
>
> By moving FIEMAP_FLAG_SYNC handling to fiemap_prep we ensure it is
> handled once instead of duplicated, but can still be done under fs locks,
> like xfs/iomap intended with its duplicate handling.  Also make sure the
> error value of filemap_write_and_wait is propagated to user space.
>
> Signed-off-by: Christoph Hellwig <hch@....de>

Nice!

Reviewed-by: Amir Goldstein <amir73il@...il.com>

Thanks for fixing this,
Amir.