linux-ext4 - Re: [PATCH v2 05/17] ext4: Allow sb to be NULL in ext4

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200429110947.GA6290@infradead.org>
Date:   Wed, 29 Apr 2020 04:09:47 -0700
From:   Christoph Hellwig <hch@...radead.org>
To:     Ian Kent <raven@...maw.net>
Cc:     Lukas Czerner <lczerner@...hat.com>,
        Christoph Hellwig <hch@...radead.org>,
        linux-ext4@...r.kernel.org, dhowells@...hat.com,
        viro@...iv.linux.org.uk
Subject: Re: [PATCH v2 05/17] ext4: Allow sb to be NULL in ext4_msg()

On Wed, Apr 29, 2020 at 10:53:00AM +0800, Ian Kent wrote:
> The mount-API log macros tend to cause user confusion because they
> often lead to unexpected log messages.
> 
> We're seeing that now with bugs logged due to unexpected messages
> resulting from the NFS mount-API conversion.
> 
> I'd recommend mostly avoiding using the macros until there's been
> time to reconsider how they should work, after all fsopen() and
> friends will still get errno errors just not the passed string
> description.

And when is that time going to be?  Should we convert existing users
back and remove that functionality if it doesn't work properly?