lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 2 May 2020 04:52:13 +0530 From: Ritesh Harjani <riteshh@...ux.ibm.com> To: Christoph Hellwig <hch@....de>, linux-ext4@...r.kernel.org, viro@...iv.linux.org.uk Cc: jack@...e.cz, tytso@....edu, adilger@...ger.ca, amir73il@...il.com, linux-fsdevel@...r.kernel.org, linux-unionfs@...r.kernel.org Subject: Re: [PATCH 05/11] fs: mark __generic_block_fiemap static On 4/27/20 11:49 PM, Christoph Hellwig wrote: > There is no caller left outside of ioctl.c. Looks fine. Feel free to add Reviewed-by: Ritesh Harjani <riteshh@...ux.ibm.com> > > Signed-off-by: Christoph Hellwig <hch@....de> > --- > fs/ioctl.c | 4 +--- > include/linux/fs.h | 4 ---- > 2 files changed, 1 insertion(+), 7 deletions(-) > > diff --git a/fs/ioctl.c b/fs/ioctl.c > index 282d45be6f453..f55f53c7824bb 100644 > --- a/fs/ioctl.c > +++ b/fs/ioctl.c > @@ -299,8 +299,7 @@ static inline loff_t blk_to_logical(struct inode *inode, sector_t blk) > * If you use this function directly, you need to do your own locking. Use > * generic_block_fiemap if you want the locking done for you. > */ > - > -int __generic_block_fiemap(struct inode *inode, > +static int __generic_block_fiemap(struct inode *inode, > struct fiemap_extent_info *fieinfo, loff_t start, > loff_t len, get_block_t *get_block) > { > @@ -445,7 +444,6 @@ int __generic_block_fiemap(struct inode *inode, > > return ret; > } > -EXPORT_SYMBOL(__generic_block_fiemap); > > /** > * generic_block_fiemap - FIEMAP for block based inodes > diff --git a/include/linux/fs.h b/include/linux/fs.h > index 4f6f59b4f22a8..3104c6f7527b5 100644 > --- a/include/linux/fs.h > +++ b/include/linux/fs.h > @@ -3299,10 +3299,6 @@ static inline int vfs_fstat(int fd, struct kstat *stat) > extern const char *vfs_get_link(struct dentry *, struct delayed_call *); > extern int vfs_readlink(struct dentry *, char __user *, int); > > -extern int __generic_block_fiemap(struct inode *inode, > - struct fiemap_extent_info *fieinfo, > - loff_t start, loff_t len, > - get_block_t *get_block); > extern int generic_block_fiemap(struct inode *inode, > struct fiemap_extent_info *fieinfo, u64 start, > u64 len, get_block_t *get_block); >
Powered by blists - more mailing lists