lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 2 May 2020 05:04:01 +0530 From: Ritesh Harjani <riteshh@...ux.ibm.com> To: Christoph Hellwig <hch@....de>, linux-ext4@...r.kernel.org, viro@...iv.linux.org.uk Cc: jack@...e.cz, tytso@....edu, adilger@...ger.ca, amir73il@...il.com, linux-fsdevel@...r.kernel.org, linux-unionfs@...r.kernel.org Subject: Re: [PATCH 07/11] iomap: fix the iomap_fiemap prototype On 4/27/20 11:49 PM, Christoph Hellwig wrote: > iomap_fiemap should take u64 start and len arguments, just like the > ->fiemap prototype. > > Signed-off-by: Christoph Hellwig <hch@....de> hmm.. I guess, it's only ->fiemap ops in inode_operations which has start and len arguments as u64. While such other ops in struct file_operations have the arguments of type loff_t. (e.g. ->fallocate, -->llseek etc). But sure to match the ->fiemap prototype, this patch looks ok to me. Feel free to add: Reviewed-by: Ritesh Harjani <riteshh@...ux.ibm.com> > --- > fs/iomap/fiemap.c | 2 +- > include/linux/iomap.h | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/fs/iomap/fiemap.c b/fs/iomap/fiemap.c > index fca3dfb9d964a..dd04e4added15 100644 > --- a/fs/iomap/fiemap.c > +++ b/fs/iomap/fiemap.c > @@ -66,7 +66,7 @@ iomap_fiemap_actor(struct inode *inode, loff_t pos, loff_t length, void *data, > } > > int iomap_fiemap(struct inode *inode, struct fiemap_extent_info *fi, > - loff_t start, loff_t len, const struct iomap_ops *ops) > + u64 start, u64 len, const struct iomap_ops *ops) > { > struct fiemap_ctx ctx; > loff_t ret; > diff --git a/include/linux/iomap.h b/include/linux/iomap.h > index 8b09463dae0db..63db02528b702 100644 > --- a/include/linux/iomap.h > +++ b/include/linux/iomap.h > @@ -178,7 +178,7 @@ int iomap_truncate_page(struct inode *inode, loff_t pos, bool *did_zero, > vm_fault_t iomap_page_mkwrite(struct vm_fault *vmf, > const struct iomap_ops *ops); > int iomap_fiemap(struct inode *inode, struct fiemap_extent_info *fieinfo, > - loff_t start, loff_t len, const struct iomap_ops *ops); > + u64 start, u64 len, const struct iomap_ops *ops); > loff_t iomap_seek_hole(struct inode *inode, loff_t offset, > const struct iomap_ops *ops); > loff_t iomap_seek_data(struct inode *inode, loff_t offset, >
Powered by blists - more mailing lists