lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 6 May 2020 11:26:52 +0200 From: Jan Kara <jack@...e.cz> To: Christoph Hellwig <hch@....de> Cc: linux-ext4@...r.kernel.org, viro@...iv.linux.org.uk, jack@...e.cz, tytso@....edu, adilger@...ger.ca, riteshh@...ux.ibm.com, amir73il@...il.com, linux-fsdevel@...r.kernel.org, linux-unionfs@...r.kernel.org Subject: Re: [PATCH 04/11] ext4: remove the call to fiemap_check_flags in ext4_fiemap On Tue 05-05-20 17:43:17, Christoph Hellwig wrote: > iomap_fiemap already calls fiemap_check_flags first thing, so this > additional check is redundant. > > Signed-off-by: Christoph Hellwig <hch@....de> > Reviewed-by: Ritesh Harjani <riteshh@...ux.ibm.com> Looks good to me. You can add: Reviewed-by: Jan Kara <jack@...e.cz> Honza > --- > fs/ext4/extents.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c > index d2a2a3ba5c44a..a41ae7c510170 100644 > --- a/fs/ext4/extents.c > +++ b/fs/ext4/extents.c > @@ -4866,9 +4866,6 @@ int ext4_fiemap(struct inode *inode, struct fiemap_extent_info *fieinfo, > fieinfo->fi_flags &= ~FIEMAP_FLAG_CACHE; > } > > - if (fiemap_check_flags(fieinfo, FIEMAP_FLAG_SYNC | FIEMAP_FLAG_XATTR)) > - return -EBADR; > - > /* > * For bitmap files the maximum size limit could be smaller than > * s_maxbytes, so check len here manually instead of just relying on the > -- > 2.26.2 > -- Jan Kara <jack@...e.com> SUSE Labs, CR
Powered by blists - more mailing lists