lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 13 May 2020 11:16:15 -0700 From: Eric Biggers <ebiggers@...nel.org> To: Satya Tangirala <satyat@...gle.com> Cc: linux-block@...r.kernel.org, linux-scsi@...r.kernel.org, linux-fscrypt@...r.kernel.org, linux-fsdevel@...r.kernel.org, linux-f2fs-devel@...ts.sourceforge.net, linux-ext4@...r.kernel.org, Barani Muthukumaran <bmuthuku@....qualcomm.com>, Kuohong Wang <kuohong.wang@...iatek.com>, Kim Boojin <boojin.kim@...sung.com> Subject: Re: [PATCH v12 06/12] scsi: ufs: UFS driver v2.1 spec crypto additions On Thu, Apr 30, 2020 at 11:59:53AM +0000, Satya Tangirala wrote: > Add the crypto registers and structs defined in v2.1 of the JEDEC UFSHCI > specification in preparation to add support for inline encryption to > UFS. > > Signed-off-by: Satya Tangirala <satyat@...gle.com> Looks good, you can add: Reviewed-by: Eric Biggers <ebiggers@...gle.com> One nit: > diff --git a/drivers/scsi/ufs/ufshcd.h b/drivers/scsi/ufs/ufshcd.h > index 6ffc08ad85f63..1eebb589159d6 100644 > --- a/drivers/scsi/ufs/ufshcd.h > +++ b/drivers/scsi/ufs/ufshcd.h > @@ -555,6 +555,12 @@ enum ufshcd_caps { > * for userspace to control the power management. > */ > UFSHCD_CAP_RPM_AUTOSUSPEND = 1 << 6, > + > + /* > + * This capability allows the host controller driver to use the > + * inline crypto engine, if it is present > + */ > + UFSHCD_CAP_CRYPTO = (1 << 7), > }; The other values of this enum don't use parentheses. - Eric
Powered by blists - more mailing lists