lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 13 May 2020 23:55:25 -0700 From: Ira Weiny <ira.weiny@...el.com> To: Jan Kara <jack@...e.cz> Cc: linux-ext4@...r.kernel.org, Andreas Dilger <adilger.kernel@...ger.ca>, "Theodore Y. Ts'o" <tytso@....edu>, Al Viro <viro@...iv.linux.org.uk>, Dan Williams <dan.j.williams@...el.com>, Dave Chinner <david@...morbit.com>, Christoph Hellwig <hch@....de>, Jeff Moyer <jmoyer@...hat.com>, "Darrick J. Wong" <darrick.wong@...cle.com>, linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH 8/9] fs/ext4: Introduce DAX inode flag On Thu, May 14, 2020 at 08:43:35AM +0200, Jan Kara wrote: > On Wed 13-05-20 14:41:55, Ira Weiny wrote: > > On Wed, May 13, 2020 at 04:47:06PM +0200, Jan Kara wrote: > > > > > > So I think you'll have to check > > > whether DAX flag is being changed, > > > > ext4_dax_dontcache() does check if the flag is being changed. > > Yes, but if you call it after inode flags change, you cannot determine that > just from flags and EXT4_I(inode)->i_flags. So that logic needs to change. I just caught this email... just after sending V1. I've moved where ext4_dax_dontcache() is called. I think it is ok now with the current check. LMK if I've messed it up... :-/ Ira > > Honza > > -- > Jan Kara <jack@...e.com> > SUSE Labs, CR
Powered by blists - more mailing lists