linux-ext4 - [PATCH] unicode: Allow building kunit test suite as a module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Tue, 19 May 2020 01:03:46 -0400
From:   Gabriel Krisman Bertazi <krisman@...labora.com>
To:     linux-ext4@...r.kernel.org
Cc:     tytso@....edu, kernel@...labora.com,
        Gabriel Krisman Bertazi <krisman@...labora.com>,
        Ricardo Cañuelo <ricardo.canuelo@...labora.com>,
        kbuild test robot <lkp@...el.com>
Subject: [PATCH] unicode: Allow building kunit test suite as a module

Starting on commit c475c77d5b56 ("kunit: allow kunit tests to be loaded
as a module") kunit testsuites need to be buildable as modules, to
prevent the undefined references below, in case KUNIT itself was made a
module:

utf8-test.c:(.text+0x48): undefined reference to `kunit_ptr_not_err_assert_format'
>> sparc64-linux-ld: utf8-test.c:(.text+0x50): undefined reference to `kunit_ptr_not_err_assert_format'
>> sparc64-linux-ld: utf8-test.c:(.text+0xb4): undefined reference to `kunit_do_assertion'
>> sparc64-linux-ld: utf8-test.c:(.text+0xbc): undefined reference to
`kunit_binary_assert_format'

This was found by 0-day on linux-next and fixes the allmodconfig build

CC: Ricardo Cañuelo <ricardo.canuelo@...labora.com>
Fixes: d269543a1dcb ("unicode: implement utf8 unit tests as a KUnit test suite")
Reported-by: kbuild test robot <lkp@...el.com>
Signed-off-by: Gabriel Krisman Bertazi <krisman@...labora.com>
---
 fs/unicode/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/unicode/Kconfig b/fs/unicode/Kconfig
index a8865891c3bd..eb30ef469567 100644
--- a/fs/unicode/Kconfig
+++ b/fs/unicode/Kconfig
@@ -9,7 +9,7 @@ config UNICODE
 	  support.
 
 config UNICODE_KUNIT_TESTS
-	bool "KUnit tests for Unicode normalization and casefolding support"
+	tristate "KUnit tests for Unicode normalization and casefolding support"
 	depends on UNICODE && KUNIT
 	default n
 	help
-- 
2.26.2