linux-ext4 - Re: [PATCH] ext4: avoid ext4_error()'s caused by ENOMEM in the truncate path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 21 May 2020 12:55:48 -0400
From:   "Theodore Y. Ts'o" <tytso@....edu>
To:     Anna Pendleton <pendleton@...gle.com>
Cc:     Andreas Dilger <adilger.kernel@...ger.ca>,
        linux-ext4@...r.kernel.org,
        Harshad Shirwadkar <harshadshirwadkar@...il.com>
Subject: Re: [PATCH] ext4: avoid ext4_error()'s caused by ENOMEM in the
 truncate path

On Thu, May 07, 2020 at 10:50:28AM -0700, Anna Pendleton wrote:
> From: Theodore Ts'o <tytso@....edu>
> 
> We can't fail in the truncate path without requiring an fsck.
> Add work around for this by using a combination of retry loops
> and the __GFP_NOFAIL flag.
> 
> From: Theodore Ts'o <tytso@....edu>
> Signed-off-by: Theodore Ts'o <tytso@....edu>
> Signed-off-by: Anna Pendleton <pendleton@...gle.com>
> Reviewed-by: Harshad Shirwadkar <harshadshirwadkar@...il.com>

Thanks, applied.

Per the feedback from the kbuild test robot, I changed "int gfp_flags =..." to
"gfp_t gfp_flags=..." in three places in the patches.

Cheers,

						- Ted