linux-ext4 - Re: [PATCH] ext4: don't block for O_DIRECT if IOCB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200529031500.GK228632@mit.edu>
Date:   Thu, 28 May 2020 23:15:00 -0400
From:   "Theodore Y. Ts'o" <tytso@....edu>
To:     Jens Axboe <axboe@...nel.dk>
Cc:     linux-ext4@...r.kernel.org
Subject: Re: [PATCH] ext4: don't block for O_DIRECT if IOCB_NOWAIT is set

On Sun, May 24, 2020 at 04:53:16PM -0600, Jens Axboe wrote:
> Running with some debug patches to detect illegal blocking triggered the
> extend/unaligned condition in ext4. If ext4 needs to extend the file (and
> hence go to buffered IO), or if the app is doing unaligned IO, then ext4
> asks the iomap code to wait for IO completion. If the caller asked for
> no-wait semantics by setting IOCB_NOWAIT, then ext4 should return -EAGAIN
> instead.
> 
> Signed-off-by: Jens Axboe <axboe@...nel.dk>

Thanks, applied.

					- Ted