lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20200601114708.GG3960@quack2.suse.cz> Date: Mon, 1 Jun 2020 13:47:08 +0200 From: Jan Kara <jack@...e.cz> To: yangerkun <yangerkun@...wei.com> Cc: tytso@....edu, jaegeuk@...nel.org, jack@...e.cz, linux-ext4@...r.kernel.org, yi.zhang@...wei.com Subject: Re: [PATCH] ext4: stop overwrite the errcode in ext4_setup_super On Mon 01-06-20 15:34:04, yangerkun wrote: > Now the errcode from ext4_commit_super will overwrite EROFS exists in > ext4_setup_super. Actually, no need to call ext4_commit_super since we > will return EROFS. Fix it by goto done directly. > > Fixes: c89128a00838 ("ext4: handle errors on ext4_commit_super") > Signed-off-by: yangerkun <yangerkun@...wei.com> Yeah, makes sense. You can add: Reviewed-by: Jan Kara <jack@...e.cz> Honza > --- > fs/ext4/super.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/fs/ext4/super.c b/fs/ext4/super.c > index bf5fcb477f66..87c5611a4c67 100644 > --- a/fs/ext4/super.c > +++ b/fs/ext4/super.c > @@ -2344,6 +2344,7 @@ static int ext4_setup_super(struct super_block *sb, struct ext4_super_block *es, > ext4_msg(sb, KERN_ERR, "revision level too high, " > "forcing read-only mode"); > err = -EROFS; > + goto done; > } > if (read_only) > goto done; > -- > 2.25.4 > -- Jan Kara <jack@...e.com> SUSE Labs, CR
Powered by blists - more mailing lists