linux-ext4 - Re: [PATCHv2 1/1] ext4: mballoc: Use this_cpu_read instead of this_cpu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200610062538.GA24975@infradead.org>
Date:   Tue, 9 Jun 2020 23:25:38 -0700
From:   Christoph Hellwig <hch@...radead.org>
To:     Ritesh Harjani <riteshh@...ux.ibm.com>
Cc:     linux-ext4@...r.kernel.org, jack@...e.com, tytso@....edu,
        Hillf Danton <hdanton@...a.com>, linux-fsdevel@...r.kernel.org,
        Borislav Petkov <bp@...en8.de>,
        Marek Szyprowski <m.szyprowski@...sung.com>,
        syzbot+82f324bb69744c5f6969@...kaller.appspotmail.com
Subject: Re: [PATCHv2 1/1] ext4: mballoc: Use this_cpu_read instead of
 this_cpu_ptr

On Tue, Jun 09, 2020 at 04:23:10PM +0530, Ritesh Harjani wrote:
> Simplify reading a seq variable by directly using this_cpu_read API
> instead of doing this_cpu_ptr and then dereferencing it.
> 
> This also avoid the below kernel BUG: which happens when
> CONFIG_DEBUG_PREEMPT is enabled

I see this warning all the time with ext4 using tests VMs, so lets get
this fixed ASAP before -rc1:

Reviewed-by: Christoph Hellwig <hch@....de>